8000 chore: debug crash on DevTools SetOwnerWindow by codebytere · Pull Request #47243 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: debug crash on DevTools SetOwnerWindow #47243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: debug crash on DevTools SetOwnerWindow #47243

wants to merge 1 commit into from
+9 −1

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented May 23, 2025 •
edited
Loading

Description of Change

Debug #47187 by:

  1. Adding SEQUENCE_CHECKER for InspectableWebContents and DCHECK_CALLED_ON_VALID_SEQUENCE to InspectableWebContents::LoadCompleted
  2. Adding DCHECK(!owner_window_.WasInvalidated()) to ensure window of the webContents holding the devtools is valid
  3. Adding DCHECK_EQ(handle->owner_window(), nullptr) to ensure the devtools does not have a owner window

Checklist

Release Notes

Notes: none

@codebytere codebytere requested review from ckerr and deepak1556 May 23, 2025 08:11
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 23, 2025
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels May 23, 2025
deepak1556
deepak1556 reviewed May 23, 2025
View reviewed changes
@codebytere codebytere force-pushed the fix-potential-race-crash branch from 44b814a to 4c9483c Compare May 23, 2025 10:40
@codebytere codebytere changed the title fix: crash on DevTools set owner window chore: debug crash on DevTools SetOwnerWindow May 23, 2025
@codebytere codebytere requested a review from deepak1556 May 23, 2025 10:42
ckerr
ckerr approved these changes May 23, 2025
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about the SEQUENCE_CHECKER macro

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @ckerr @deepak1556
0