fix: nodeIntegrationInWorker not working in AudioWorklet
#47244
Conversation
|
If multiple worklet contexts share the same thread which was also the case before https://chromium-review.googlesource.com/c/chromium/src/+/5270028 , previously we would bail early before associating the Node environment to the new worker context and now
|
There was a problem hiding this comment.
Blocking the change since it is incomplete in its current state. For ex:
In the test case, update the renderer code to
const workletPath = './worklet.js';
async function createContextAndLoadWorklet(channel = false, path = workletPath) {
const audioCtx = new AudioContext();
await audioCtx.audioWorklet.addModule(path);
if (channel) {
const node = new AudioWorkletNode(audioCtx, "audio-worklet");
node.port.onmessage = (e) => {
console.log(e.data);
node.port.postMessage("pong");
}
node.connect(audioCtx.destination);
}
await audioCtx.close();
}
createContextAndLoadWorklet()
.then(() => { return createContextAndLoadWorklet(); })
.then(() => { return createContextAndLoadWorklet(); })
.then(() => { return createContextAndLoadWorklet(); })
.then(() => { return createContextAndLoadWorklet(true); })
.then(() => { return createContextAndLoadWorklet(); })and worklet code to
// Empty
console.log('worklet globalThis', globalThis, 'Is require a function?', typeof require === 'function');
const { setInterval } = require('node:timers');
class AudioWorklet extends AudioWorkletProcessor {
constructor() {
super();
setInterval(() => {
this.port.postMessage("ping");
}, 1000);
this.port.onmessage = (e) => console.log(e.data);
}
process() {
return true;
}
}
registerProcessor('audio-worklet', AudioWorklet);the creation of the 6th worklet which shares the same thread will cause the node integration to be reinitialized and will break the ping-pong loop.
Description of Change
Closes #41263
Refs CL:5270028
With Chromium's new AudioWo 8000 rklet thread pooling system in CL:5270028, threads are reused for multiple AudioWorklet contexts. This breaks nodeIntegrationInWorker functionality for the 4th+ AudioWorklet instances due to incorrect thread-local observer management.
This causes subsequent contexts on reused threads to fail Node.js environment setup, breaking nodeIntegrationInWorker functionality for the 4th+ AudioWorklet instances. When an observer exists on a reused thread, it incorrectly skipped Node.js setup for new contexts.
Tested with https://gist.github.com/5a8ab93852ccb201057a9f3e813af47b
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
nodeIntegrationInWorkerdidn't always work in AudioWorklet