fix: remove Windows-specific cleanup from postinstall script #3911
+54
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove rimraf node_modules/.bin/*.ps1 from postinstall script - Add CROSS_PLATFORM.md with documentation and future considerations - Improve cross-platform compatibility for non-Windows systems This change fixes the postinstall script failure on non-Windows systems where PowerShell scripts do not exist, while maintaining the essential TypeScript configuration generation steps. Resolves issue with postinstall script failing on Unix systems.
malept
requested changes
Apr 4, 2025
There was a problem hiding this comment.
I'm confused. Why is there a new document for a contributor to read, instead of just creating the script that's literally written in a code block in the doc?
Also, it would help if you provided detailed steps to reproduce this issue on either macOS or Linux, plus the OS/architecture/Node.js version that you used. I am surprised that this would be an issue, given that most contributors either use macOS or Linux.
erickzhao
requested changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a cross-platform compatibility issue in the postinstall script that affects non-Windows systems.
Changes
rimraf node_modules/.bin/*.ps1from postinstall scriptCROSS_PLATFORM.mdwith documentation and future considerationsProblem
The postinstall script was failing on Unix systems (macOS/Linux) because it attempted to remove Windows PowerShell scripts (
.ps1) that don't exist on these platforms. This prevented the essential TypeScript configuration generation steps from completing successfully.Solution
CROSS_PLATFORM.mdexplaining the change and providing future considerationsTesting
yarn test:fastwith all tests passingThis change resolves the postinstall script failure on Unix systems while preserving the core functionality of the TypeScript configuration generation steps.