8000 fix: SEA should not throw unless script errors on exit by felixrieseberg · Pull Request #57 · electron/windows-sign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: SEA should not throw unless script errors on exit #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

fix: SEA should not throw unless script errors on exit #57

merged 1 commit into from
May 2, 2025

Conversation

felixrieseberg
Copy link
Member
@felixrieseberg felixrieseberg commented May 2, 2025 •
edited
Loading

Depending on the shell used (like PowerShell), a lot of output will be auto-piped to stderr - even if it's not an error at all. That has entire build pipelines failing even though there is no error at all.

To fix this, we'll look at the exit code of the invoked script. If the process exited with anything other than 0, we'll error and bubble up stderr.

We didn't notice that earlier because I am an insane person using git bash every now and then

@felixrieseberg felixrieseberg requested a review from a team as a code owner May 2, 2025 19:16
@felixrieseberg felixrieseberg merged commit c2a0c78 into main May 2, 2025
7 checks passed
@felixrieseberg felixrieseberg deleted the felixr-fix-stderr branch May 2, 2025 19:53
@continuous-auth Continuous Auth
Copy link

🎉 This PR is included in version 1.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nikwen
Copy link
Member
nikwen commented May 6, 2025 •
edited
Loading

Nice, now we can update this paragraph of the Electron Forge code signing docs:

image

https://www.electronforge.io/guides/code-signing/code-signing-windows#configuring-forge-trusted-signing

Follow up: electron-forge/electron-forge-docs#230

@nikwen nikwen mentioned this pull request May 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaietta mmaietta mmaietta approved these changes

@erikian erikian erikian approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixrieseberg @nikwen @mmaietta @erikian
0