Disable SetShadingRate when not supported. #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alan,
I tracked down the issue where ModelViewer.gg was causing my viewer to hang. I had run a development build through Visual Studio to get the D3D12 error messages. The short of it is that my system does not support variable-rate shading. I'm a little surprised ... I'm on Windows version
10.0.19045 Build 19045
which should be higher than version1903
. That said, my graphics device (a Radeon RX 570) is dated.I was able to disable the sparse sampling path to render the bunny. I'm not sure what optional capabilities looks like in Gigi or whether it's desirable but I figure it's worth sharing if there are others limited by such an issue.
Kind regards, Kyle.
Screenshot
Output