10000 API Add diskUsage by xezpeleta · Pull Request #604 · elkarbackup/elkarbackup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

API Add diskUsage #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

API Add diskUsage #604

wants to merge 5 commits into from

Conversation

xezpeleta
Copy link
Contributor

Currently diskUsage is always 0 as the getter is not implemented.

#599

@xezpeleta
Copy link
Contributor Author

To be honest I have no idea what I'm doing 😆 so somebody should review this patch...

Tests are ok in my local environment, but it's failing in GitHub CI. Does it mean I did something wrong? Or should we increase the PHP memory_limit in the Docker image?

image

@xezpeleta xezpeleta requested a review from elacunza September 14, 2021 12:23
elacunza
elacunza reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor
@elacunza elacunza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As diskUsage is calculated I think we shouldn't accept a value for it when creating or updating a job. Just showing the correct value when getting should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elacunza elacunza elacunza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xezpeleta @elacunza
0