Propagate opts configured in prepare_query/3 to preloads
#4637
Conversation
|
Fantastic, could we perhaps have a test? We have some unit tests in Ecto.Repo where we send messages or use the process dictionary for the options, perhaps this could be added there? Thank you. |
|
Good god you're quick. I was editing my main comment and got a little jump scare from your reply 😂 Happy to know that it could be merged. I will add a test. |
This ensures that when `:on_preloader_spawn` is set in the `prepare_query/3` callback, it is propagated to the preloader.
c331940 to
c92d8a8
Compare
|
I thought I'd just fix up a test and the PR would be good, but it turns out we'd also have to run This also turned out to be a red herring -- someone figured out how to link Ecto preloads ages ago (using pdict So I've pushed to the branch, and I'm leaving a note here for myself (or anyone else who wants to pick this up later). And closing the PR for now. |
This ensures that when
:on_preloader_spawnis set in theprepare_query/3callback, it is propagated to the preloader.(For avoidance of XY issues, I am trying to find a way to propagate opentelemetry tracing context into the preloads, so that preloaded queries can appear in my opentelemetry traces like normal, and not appear as orphaned spans. The
on_preloader_spawnoption appears to be designed for exactly this. But, there is currently no convenient way to set this globally. Currently it only works when you add it to the opts in Repo.all/3 etc)