Add IBusRegistrationContext to Transport Configuration Actions #6413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions as the source for the prefetch count as the new source for this information is in the base MassTransitOptions. Created a new ConfigureTransportBus in both RabbitMQ and Azure Service Bus to support the context in the configuration action. Marked the old ConfigureServiceBus to persuade migration over to the contextual action. Currently, it will run the legacy action first and then the new contextual action second. The Elsa.Server.Web was also updated to use the new ConfigureTransportBus.
Added minor changes to MassTransitFeature to start using MassTransitOptions as the source for the prefetch count as the new source for this information is in the base MassTransitOptions. Created a new ConfigureTransportBus in both RabbitMQ and Azure Service Bus to support the context in the configuration action. Marked the old ConfigureServiceBus to persuade migration over to the contextual action. Currently, it will run the legacy action first and then the new contextual action second. The Elsa.Server.Web was also updated to use the new ConfigureTransportBus.
|
@dotnet-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates MassTransit configuration for Azure Service Bus and RabbitMQ. Previously, the IBusRegistrationContext was not included in the configuration action and prevents configuration of additional MassTransit components that require the context being passed in.
Program.cs: ReplacesConfigureServiceBuswithConfigureTransportBusas the old action is now obsolete.AzureServiceBusFeature.csandRabbitMqServiceBusFeature.cs: MarksConfigureServiceBusas obsolete, introducesConfigureTransportBus. Added XML documentation to bring awareness to the alternative action and some clarification that this action runs in addition to Elsa's standard configuration.MassTransitFeature.cs: UpdatesConfigureInMemoryTransportmethod documentation and updatesAddMassTransitmethod within to includeMassTransitOptionsconfiguration for prefetch count. While not directly part of the change, it was made becausePrefetchCountwas marked as obsolete in the feature class.NOTE: A name of ConfigureTransportBus was chosen for the new action to avoid conflicts with the old ConfigureServiceBus. Given that both ASB and RMQ are both transports in the eyes of MassTransit, it made the most sense to go this route without doing something like ConfigureServiceBusWithContext or similar.
This change is