Remove obsolete properties and refactor activity evaluation #6603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored activity input and log persistence property evaluation using improved notification handlers. Removed redundant `ActivityState` property and associated serialization logic, ensuring payloads are only serialized when necessary. All changes streamline workflow processing and enhance maintainability.
Replaced the separate variable for the cancellation token with an inline reference for clarity and reduced redundancy. This simplifies the code without altering functionality.
raymonddenhaan
approved these changes
Apr 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes the obsolete ActivityState property and refactors several aspects of activity evaluation and log persistence to streamline workflow processing. Key changes include:
- Removing the redundant ActivityState property and associated serialization logic.
- Refactoring payload serialization in log stores and mappers.
- Adding improved notification handlers to ensure parent activity properties and log persistence modes are properly evaluated.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/Elsa.Workflows.Runtime/Services/WorkflowExecutionLogRecordExtractor.cs | Removed extraction of outdated ActivityState. |
| src/modules/Elsa.Workflows.Runtime/Services/DefaultActivityExecutionMapper.cs | Replaced payload extraction with journal data and removed legacy method. |
| src/modules/Elsa.Workflows.Runtime/LogPersistence/Handlers/EvaluateParentInputProperties.cs | Introduced handler for evaluating parent input properties. |
| src/modules/Elsa.Workflows.Runtime/LogPersistence/Extensions/ActivityExecutionContextExtensions.cs | Added HasLogPersistenceModeMap method. |
| src/modules/Elsa.Workflows.Runtime/Features/WorkflowRuntimeFeature.cs | Added notification handler for EvaluateParentLogPersistenceModes. |
| src/modules/Elsa.Workflows.Runtime/Entities/WorkflowExecutionLogRecord.cs | Marked ActivityState as obsolete. |
| src/modules/Elsa.Workflows.Core/Notifications/InvokingActivityCallback.cs | Introduced new notification record for invoking activity callbacks. |
| src/modules/Elsa.Workflows.Core/Middleware/Activities/ExecutionLogMiddleware.cs | Removed the payload from the "Suspended" log entry. |
| src/modules/Elsa.Workflows.Core/Handlers/EvaluateParentInputProperties.cs | Ensured properties are evaluated before parent invocation. |
| src/modules/Elsa.Workflows.Core/Extensions/ActivityExecutionContextExtensions.cs | Updated canceled log entry to remove payload. |
| src/modules/Elsa.Workflows.Core/Contexts/ActivityExecutionContext.Complete.cs | Updated completed log entry to remove payload. |
| src/modules/Elsa.Workflows.Core/Contexts/ActivityExecutionContext.Cancel.cs | Updated canceled log entry to remove payload. |
| src/modules/Elsa.Workflows.Core/Behaviors/ScheduledChildCallbackBehavior.cs | Updated child callback behavior to invoke parent evaluation via a notification. |
| src/modules/El 8000 sa.Workflows.Core/Abstractions/Activity.cs | Refactored constructors and property defaults. |
| src/modules/Elsa.Workflows.Api/Models/ExecutionLogRecord.cs | Marked ActivityState as obsolete on API models. |
| src/modules/Elsa.Scheduling/Activities/Cron.cs | Updated constructor defaults from default to null. |
| src/modules/Elsa.EntityFrameworkCore/Modules/Runtime/WorkflowExecutionLogStore.cs | Refactored payload serialization logic. |
| src/modules/Elsa.Dapper/Modules/Runtime/Stores/DapperWorkflowExecutionLogStore.cs | Refactored payload serialization and mapping for log records. |
Comments suppressed due to low confidence (1)
src/modules/Elsa.Workflows.Core/Behaviors/ScheduledChildCallbackBehavior.cs:35
- The variable 'context' is not defined in this scope. Consider using an available cancellation token (for example, from activityExecutionContext or passing a cancellation token variable) to ensure the notification is sent with the appropriate cancellation settings.
await mediator.SendAsync(invokingActivityCallbackNotification, context.CancellationToken);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored activity input and log persistence property evaluation using improved notification handlers. Removed redundant
ActivityStateproperty and associated serialization logic, ensuring payloads are only serialized when necessary. All changes streamline workflow processing and enhance maintainability.This change is