Start a new workflow trace when triggered from UI #6606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfmskywalker
approved these changes
Apr 23, 2025
Comment on lines
12
to
21
| /// <summary> | ||
| /// When active this will create a new root Activity if the current Activity has a remote parent. | ||
| /// </summary> | ||
| public bool UseNewRootActivityForRemoteParent { get; set; } = true; | ||
|
|
||
| /// <summary> | ||
| /// Determines if instead of a empty parent, a dummy parent Activity should be used to create a new Root Activity. | ||
| /// </summary> | ||
| /// <remarks>This is needed when middleware is active that uses the previous Parent Activity despite creating an Activity based on an empty Parent.</remarks> | ||
| public bool UseDummyParentActivityAsRootSpan { get; set; } = false; |
There was a problem hiding this comment.
Should we include a comment that these settings exist for the purpose of mitigating a limitation with the datadog autoinstrumentation?
There was a problem hiding this comment.
I didn't mention Datadog directly, however I tried to use the message in the remarks tag to get this point across. Is there anything you are missing in this?
There was a problem hiding this comment.
Unless I misunderstood, this effect is directly tied to what Datadog's auto instrumentation is doing, so for me it would be helpful to have that context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to use a dummy activity as a hack to prevent other middleware of reinstating the parent activity
This change is