refactoring for GIT_SELF tests #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mods to allow building src/app tree with hunter managed acf build via the magic of GIT_SELF. Some library layout changes are required to keep private and public acf headers separate.
The util (and io) directory contains utility classes/functions used by the acf library. In this context they are effectively non-exported == private headers. They are also used as a support lib in the various console apps and unit tests within the repository.
The util directory sits parallel with the root acf folder so that the target_include_directories() calls can include util headers without automatically including acf headers from the repository tree, as we want to make sure the acf folder includes can be provided exclusively from the the installed/managed acf package, using:
```
hunter_config(acf GIT_SELF ...)
```
Layout:
```
lib
+-util : utility function
+-io : io/serialization functions
+-acf
+-acf : acf implementation
```
Example src/app/acf/acf.cpp:
```
#include <acf/ACF.h> // from ${HOME}/.hunter/<SNIP>/Install/acf
#include <util/Logger.h> // provided from acf/src/lib/util (in-repo)
int main(int argc, char **argv)
{
// snip
}
```
* rework src/lib/{io,acf/acf,util} layout
* add support for GIT_SELF based builds of src/app tree and provide cmake/Hunte/config.cmake to support this
* update drishti-upload
* update apps for latest cxxopts parse return type
* remove unused functions/files: string_utils.h and timing.h
* update .gitignore (_*/)
|
Addresses #88 |
ruslo
approved these changes
Jun 10, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mods to allow building src/app tree with hunter managed acf build via the magic of GIT_SELF. Some library layout changes are required to keep private and public acf headers separate.
The util (and io) directory contains utility classes/functions used by the acf library. In this context they are effectively non-exported == private headers. They are also used as a support lib in the various console apps and unit tests within the repository.
The util directory sits parallel with the root acf folder so that the target_include_directories() calls can include util headers without automatically including acf headers from the repository tree, as we want to make sure the acf folder includes can be provided exclusively from the the installed/managed acf package, using:
Layout:
Example src/app/acf/acf.cpp: