build(docker): add prebuilt images to ghcr.io #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnokiUN
reviewed
Dec 31, 2022
|
LGTM, thanks Oliver! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits
docker-compose.ymlinto 3 files.docker-compose.override.ymldoes not define ports so it can utiliseextendssince oprish, pand, and effiw are very similar in setup.docker-compose.prebuilt.ymluses theghcr.ioimages anddocker-compose.ymlbuilds the images locally.The CI in
.github/workflows/build.ymluses a matrix for all 3 microservices.logout: falseresolves weird magic when the second and third services try to push, and the first service built logs out. Metadata'stagsis documented in https://github.com/docker/metadata-action, semver tags will be made when a git tag is pushed - ideally with GitHub releases.This also refactors
Dockerfiles to remove thePORTarg - since that requires a re-build and compose can simply pass through.Enoki based.