fix: raise error when model not found #2737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Raise an error when model not found using get_model_meta instead of returning empty model_meta
2) Added more helpful error messages
```py
import mteb
meta = mteb.get_model_meta("BAAI/bge-m3")
# Before fix: returns empty model meta and raises a warning that it was not found on HF
# expected behaviour: Raise an error
# After fix: Raises the following error:
# KeyError: "Model 'BAI/bge-m3' not found in MTEB registry nor on the Huggingface Hub. Did you mean: 'BAAI/bge-m3' or BAAI/bge-small-zh?"
```
This is technically a breaking change, I can move it to v2?
@x-tabdeveloping was initially developed by you as a part of the leaderboard. I couldn't find a place in the leaderboard where it is called, but I want to double check with you.
|
Seems like a reasonable idea to me. If it works and doesn't break anything then go ahead. I might stick to v2 though |
|
Yes, I think this is breaking. Even our tests can't handle it correctly |
|
Will move it to v2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change, I can move it to v2?
@x-tabdeveloping was initially developed by you as a part of the leaderboard. I couldn't find a place in the leaderboard where it is called, but I want to double check with you.
Checklist