Add multizone types #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eminence
requested changes
Jul 12, 2022
lifx-core/src/lib.rs
Outdated
| reserved7: u32, | ||
| reserved8: u32, | ||
| /// The parameters that was used in the request. | ||
| parameters: [u8; 32], |
There was a problem hiding this comment.
The lifx docs say this:
This field is 8
4byte fields which change meaning based on the effect that is running.
I'm wondering if it makes sense to write this field as a [u32; 8] ?
There was a problem hiding this comment.
Yeah, that would make more sense Ithink.
There was a problem hiding this comment.
Would you want parameters in StateMultiZoneEffect updated to match?
eminence
approved these changes
Jul 13, 2022
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the multizone types from the lifx developer docs.