8000 Add tests of captured messages to ensure they are correct by Firstyear · Pull Request #6 · eminence/lifx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add tests of captured messages to ensure th 8000 ey are correct #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2022

Conversation

Firstyear
Copy link
Contributor

This extends my previous commit with tests to ensure that everything works as intended. These were packet captured between my iOS device and a LIFX Z strip, and I used them to check that everything was happy.

@eliasfloreteng
Copy link
Contributor

It's great to test with example packets but shouldn't the tests also assert that msg is the right type of message and has the right values to assure it gets parsed correctly. Instead of just printing it?

@Firstyear
Copy link
Contributor Author

Opps good point! This will teach me for half-assing commits while busy ^^; :)

@Firstyear
Copy link
Contributor Author

Fixed, sorry about that!

@eminence
Copy link
Owner

Looks good, thanks!

@eminence eminence merged commit e3e1d8e into eminence:master Jul 16, 2022
@Firstyear
Copy link
Contributor Author

Thank you @eminence !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0