8000 Implement validation error handling by anweiss · Pull Request #12 · eminence/lifx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement validation error handling #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement validation error handling #12

wants to merge 3 commits into from

Conversation

anweiss
Copy link
@anweiss anweiss commented Aug 4, 2022

Implements #10 with some basic error handling logic.

eminence
eminence requested changes Aug 13, 2022
View reviewed changes
Copy link
Owner
@eminence eminence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There are a few smallish changes to be make, otherwise this looks good

@brianmay
Copy link

What is the status of this PR? Looks like the CI logs have expired, so I can't see why they failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eminence eminence eminence requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anweiss @brianmay @eminence
0