Better support for opening EMI screens from non-handled screens #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the behaviour where, upon closing the recipe screen that was opened from the FTB Quests screen, the client is returned to the inventory screen instead of the original quest screen.
emilyploszaj
requested changes
May 17, 2025
There was a problem hiding this comment.
This likely works to fix this issue, but does it cause other issues? for instance, if you open from another GUI, it'll show no recipes as craftable, even if they may be craftable via the currently open screen handler? maybe getHandledScreen should default to that so we can support both use cases.
| @@ -97,6 +97,7 @@ public static <T extends ScreenHandler> List<EmiRecipeHandler<T>> getAllHandlers | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
| public static <T extends ScreenHandler> @Nullable EmiRecipeHandler<T> getFirstValidHandler(EmiRecipe recipe, HandledScreen<T> screen) { | |||
| if (screen == null) return null; | |||
There was a problem hiding this comment.
Nit: EMI codebase style has brackets for all if statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour where, upon closing the recipe screen that was opened from the FTB Quests screen, the client is returned to the inventory screen instead of the original quest screen.