Remove id_source parameter from ui.indent
#4068
Open
+5
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Feb 19, 2024
| @@ -174,7 +174,7 @@ impl CollapsingState { | |||
| ) -> Option<InnerResponse<R>> { | |||
| let id = self.id; | |||
| self.show_body_unindented(ui, |ui| { | |||
| ui.indent(id, |ui| { | |||
| ui.indent(|ui| { | |||
There was a problem hiding this comment.
I haven't looked to closely at this yet, but we need to make sure the id of CollapsingHeader is not ignored. This is so that two collapsing headers in the same ui won't have an id clash.
Perhaps we need a indent_with_id_source just for this use case, or add an extra ui.push_id call here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id_sourceparameter for ui.indent #4066I have read all and made all actions you have asked in pull request template but I am unable to run scripts/check.sh cause I am on windows 11 right now. Maybe I will do it later when I boot into ubuntu or someone else can do it later if required
All tests (except 9 ignored) are passing succesfully
