egui_extras: Enable setting DatePickerButton start and end year explicitly #7061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7061-datepickeryears |
emilk
requested changes
Jun 15, 2025
Comment on lines
108
to
121
|
|
||
| /// Set the start year for the date picker. (Default: None) | ||
| #[inline] | ||
| pub fn start_year(mut self, start_year: i32) -> Self { | ||
| self.start_year = Some(start_year); | ||
| self | ||
| } | ||
|
|
||
| /// Set the end year for the date picker. (Default: None) | ||
| #[inline] | ||
| pub fn end_year(mut self, end_year: i32) -> Self { | ||
| self.end_year = Some(end_year); | ||
| self | ||
| } |
There was a problem hiding this comment.
I suggest you simplify this with a single call with a RangeInclusive. I suspect that if you set one, you want to set both.
You should also explain what it is for (the dropdown of years you can choose from)
|
Thanks for the feedback, @emilk. That makes sense, and I've updated accordingly. |
emilk
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to set the
DatePickerButton's start and end years via newstart_yearandend_yearmethods.Continue to use the existing today - 100 years and today + 10 years behavior if a year is not specified.