Workaround top area not clickable on MacOS fullscreen #7281
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7281-lucasfix-macos-fullscreen |
emilk
reviewed
Jul 1, 2025
| // Fix the top window area not being clickable on macOS when in fullscreen on an external display | ||
| // See https://github.com/rust-windowing/winit/issues/4295, https://github.com/rerun-io/rerun/issues/10280 | ||
| #[cfg(all(target_os = "macos", not(feature = "accesskit")))] | ||
| let viewport_builder = viewport_builder.with_visible(true); |
There was a problem hiding this comment.
Looks like this will cause a white flash on Windows again:
There was a problem hiding this comment.
It shouldn't, unless my cfg statement is wrong 😬
emilk
approved these changes
Jul 1, 2025
emilk
reviewed
Jul 1, 2025
Comment on lines
158
to
+163
| .with_visible(false); // Start hidden until we render the first frame to fix white flash on startup (https://github.com/emilk/egui/pull/3631) | ||
|
|
||
| // Fix the top window area not being clickable on macOS when in fullscreen on an external display | ||
| // See https://github.com/rust-windowing/winit/issues/4295, https://github.com/rerun-io/rerun/issues/10280 | ||
| #[cfg(all(target_os = "macos", not(feature = "accesskit")))] | ||
| let winit_window_builder = winit_window_builder.with_visible(true); |
There was a problem hiding this comment.
I tend to prefer the cfg! macro, because I find it leads to easier-to-read code:
| // Fix the top window area not being clickable on macOS when in fullscreen on an external display | ||
| // See https://github.com/rust-windowing/winit/issues/4295, https://github.com/rerun-io/rerun/issues/10280 | ||
| #[cfg(all(target_os = "macos", not(feature = "accesskit")))] | ||
| let viewport_builder = viewport_builder.with_visible(true); |
There was a problem hiding this comment.
We can make a reusable function for this that better explain the if-and-why of it:
fn start_visible() {
if cfg!(feature = "accesskit") {
true // accesskit requires this: $LINK
} else if cfg!(windows) {
true // Fixes white flash on startup (https://github.com/emilk/egui/pull/3631)
} else if cfg!(target_os = "macos") {
// Fix the top window area not being clickable on macOS when in fullscreen on an external display
// See https://github.com/rust-windowing/winit/issues/4295, https://github.com/rerun-io/rerun/issues/10280
false
} else {
true // no known preference one way or the other
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this only works when the accesskit feature is disabled, since accesskit requires the window to be hidden on first frame.
To test:
cargo run -p egui_demo_app --no-default-features --features glowshould work andcargo run -p egui_demo_appshould not work