Free textures after submitting queue instead of before with wgpu renderer on Web #7291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7291-fix-spurious-webgl-crashes |
lucasmerlin
approved these changes
Jul 2, 2025
|
Glow doesn't have the equivalent destroy & queue poisoning logic that wgpu/WebGPU has, so I think we covered everything now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly the same fix as
but for the web painter.
Curiously, this only surfaced now and only on WebGL - I believe this might fix
but still need to confirm.
Likely this wasn't an issue before because there were some helpful bugs (;)) in wgpu's WebGL impl before. But I do wonder why this wouldn't also be a problem on WebGPU