Make the background in SidePanel fill the available space
#1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba6b40e to
2d23455
Compare
|
Rebased on top of current master and fixed compilation errors |
emilk
reviewed
Apr 3, 2022
| let mut rect = ui.min_rect(); | ||
| rect.min -= Vec2::new(frame.margin.left, frame.margin.top); | ||
| rect.max += Vec2::new(frame.margin.right, frame.margin.bottom); | ||
| ui.allocate_space(ui.available_size()); |
There was a problem hiding this comment.
How does this work for left panels? Don't they just take up the entire width of the screen?
There was a problem hiding this comment.
Good question. It seems to work fine and I think this is because the panel_ui given to the SidePanel has a its max_width set to the width of the panel, which initially is default_width and then ui.min_rect().width() for subsequent frames. I am not too familiar with the inner workings of the layout engine, but it seems to be this rect only grows if contents overflow somehow?
See Side::set_rect_width, the definition of panel_rect and panel_ui.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small hack to fix #1262. It works by measuring the the size of the content in the panel with
ui.min_rect(), before finally usingui.allocate_space(ui.available_size())to force the frame to fill all the available space. Since be measured the size of the content before the space allocation this should not aff 8000 ect how much space the panel occupies in subsequent frames.