8000 Re-enable egui-winit for egui-glow on web by Talon1024 · Pull Request #2701 · emilk/egui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Re-enable egui-winit for egui-glow on web #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Re-enable egui-winit for egui-glow on web #2701

wants to merge 1 commit into from

Conversation

Talon1024
Copy link
@Talon1024 8000 Talon1024 commented Feb 9, 2023

I tried this myself, and I do not think there is any reason to block the winit feature from egui-glow on wasm platforms.

@Talon1024
Re-enable egui-winit on web
5daf23c 
I tried this myself, and I do not think there is any reason to block the winit feature from egui-glow on wasm platforms.
@Talon1024 Talon1024 changed the title Re-enable egui-winit on web Re-enable egui-winit for egui-glow on web Feb 9, 2023
@KentaTheBugMaker
Copy link
Contributor
KentaTheBugMaker commented Feb 10, 2023 •
edited
Loading

winit don't support IME on wasm32 platform so we have to use own eframe's implementation.
If we disable IME we can't type Chinese Japanese Korean languages.
If we enable winit feature on wasm32 platform we should warn about IME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Talon1024 @KentaTheBugMaker
0