10000 Fix some characters not correctly displaying on Windows · Issue #5 · emprcl/signls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix some characters not correctly displaying on Windows #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xaviergodart opened this issue Nov 6, 2024 · 1 comment
Open

Fix some characters not correctly displaying on Windows #5

xaviergodart opened this issue Nov 6, 2024 · 1 comment
Labels
bug Something isn't working windows

Comments

@xaviergodart
Copy link
Member

Some combining unicode characters are not displaying correctly under windows, creating gaps in the UI, making it unusable.
This is because the windows console (conhost.exe) doesn't support combining codes.

There's this normalization package that should allow us to fix the problem: golang.org/x/text/unicode/norm
@xaviergodart xaviergodart added bug Something isn't working windows labels Nov 6, 2024
xaviergodart added a commit that referenced this issue Nov 6, 2024
@xaviergodart
add combining unicode char normalization (#5)
84e1024
xaviergodart added a commit that referenced this issue Nov 6, 2024
@xaviergodart
prevent combining unicode characters to display on windows (#5)
9c12334
xaviergodart added a commit that referenced this issue Nov 6, 2024
@xaviergodart
prevent combining unicode characters to display on windows (#5)
a544ecf
@xaviergodart
Copy link
Member Author

It seems to be a windows terminal problem. Using a combining unicode character always add a whitespace right after it, breaking the whole UI. I'm not exactly sure what's happening, but there are a bunch of issues regarding unicode on the windows terminal repository.

For now, I'll just strip out all combining unicode characters for the windows build.

It's available in v0.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xaviergodart
0