feat(desktop): save and restore window state #1852
Conversation
|
So many thanks for implementing the window state persistence feature! The implementation looks thoughtful and handles the multi-monitor scenario well. Here are some thoughts that might be helpful:
// Example approach:
electronStore.set('windowState', {
bounds: win.getBounds(),
isMaximized: win.isMaximized()
})
try {
win.setBounds(savedBounds)
} catch (error) {
// log some error here
console.error('Failed to restore window bounds:', error)
// Handle fallback
}
Only when we open it for the first time do we use 1025 * 749 as the default value? const defaultBounds = {
width: 1024,
height: 768,
x: 0,
y: 0
} |
|
I'm considering removing the height and width fields from SettingEntity Reasons:
|
|
@ni00 Thank you very much for your contribution to the project! I have optimized the existing code and resolved the building error. I completely agree with your views on storing window width and height data. In version v1.x, we will no longer use the width and height from the database table. These have already been removed in version v2.x. For more details on the changes, please see: #1868 |
|
Thanks to all @ni00 @Red-Asuka |
PR Checklist
What is the current behavior?
Won't save and restore window position and size.
Issue Number
#1849
What is the new behavior?
Save and restore window position and size.
Does this PR introduce a breaking change?
Specific Instructions
Other information
reference: electron/electron#526