8000 chore: bump electron version to 33.0.0 by ysfscream · Pull Request #1909 · emqx/MQTTX · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: bump electron version to 33.0.0 #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2025
Merged

chore: bump electron version to 33.0.0 #1909

merged 4 commits into from
Mar 26, 2025

Conversation

ysfscream
Copy link
Member
@ysfscream ysfscream commented Mar 26, 2025 •
edited
Loading

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

The current built-in Node.js environment in Electron cannot use many of the new features of Node.js.

What is the new behavior?

Upgrade to Electron 33.0.0

[ENV] Node.js version: 20.18.3
[ENV] Electron version: 33.4.6
[ENV] Chrome version: 130.0.6723.191
image

Does this PR introduce a breaking change?

  • Yes
  • No

@ysfscream ysfscream requested a review from Red-Asuka March 26, 2025 16:16
@ysfscream ysfscream self-assigned this Mar 26, 2025
@ysfscream ysfscream added dependencies Pull requests that update a dependency file chore Changes in build tools or dependent packages desktop MQTTX Desktop labels Mar 26, 2025
@ysfscream ysfscream moved this to In Progress in MQTTX Mar 26, 2025
@ysfscream ysfscream added this to the v1.12.0 milestone Mar 26, 2025
@ysfscream ysfscream added upgrade Version upgrade CI/CD labels Mar 26, 2025
@ysfscream
Copy link
Member Author

@Red-Asuka, I will merge first, I want to test whether the release of 1.12.0-beta 2 is available beta.1 cannot use MCP in a production environment

@ysfscream ysfscream merged commit 9146beb into main Mar 26, 2025
10 checks passed
@ysfscream ysfscream deleted the ysf/desktop branch March 26, 2025 17:02
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQTTX Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Red-Asuka Red-Asuka Awaiting requested review from Red-Asuka

Assignees

@ysfscream ysfscream

Labels
chore Changes in build tools or dependent packages CI/CD dependencies Pull requests that update a dependency file desktop MQTTX Desktop upgrade Version upgrade
Projects
MQTTX
Status: Done
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ysfscream
0