fix(ci): skip Docker/artifact uploads for pre-releases #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-Asuka
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
Currently, the CI/CD workflows for building packages, the CLI, and the web application trigger deployment/publishing actions (like uploading to AWS S3, publishing Docker images) for all GitHub releases, including pre-releases.
Issue Number
N/A
What is the new behavior?
The GitHub Actions workflows (
build_packages.yaml,build_cli.yaml,deploy_web.yaml) have been updated. Now, steps related to deploying to external services (AWS S3, Docker Hub) will only run for full releases (releaseevent whereprereleaseis false). Actions like publishing to npm and deploying the website were already correctly configured. Uploading artifacts directly to the GitHub Release page remains unchanged and will happen for both pre-releases and full releases.Does this PR introduce a breaking change?
Specific Instructions
These changes modify the conditional logic within the GitHub Actions workflow files in the
.github/workflows/directory to differentiate between pre-releases and full releases for deployment steps. Reviewers should check theifconditions added to the relevant jobs/steps.Other information
This change ensures that pre-releases do not trigger production deployments to AWS S3 or Docker Hub, allowing for safer testing and staging via GitHub pre-releases.