fix(desktop): fix generate the latest.yaml issue on ci #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the generation issue of latest.yaml on CI by modifying configuration settings for the desktop build.
- Updated the publish configuration in vue.config.js to enable releases using a generic provider.
- Adjusted whitespace in src/background.ts for consistent code formatting.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vue.config.js | Enabled the publish configuration to support generic releases. |
| src/background.ts | Removed an unnecessary blank line to maintain consistent formatting. |
Comments suppressed due to low confidence (2)
vue.config.js:95
- Ensure that the new publish configuration meets all CI requirements for generating latest.yaml. Verify with the build logs that this change addresses the issue on the CI pipeline.
publish: [
src/background.ts:35
- [nitpick] The whitespace removal appears to be a formatting change. Confirm that the adjustment aligns with the project’s code style guidelines.
console.log('[ENV] Node.js version:', process.versions.node)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix these errors: https://github.com/emqx/MQTTX/actions/runs/14089434360