8000 ci: translate issue in Chinese into English by Rory-Z · Pull Request #1938 · emqx/MQTTX · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: translate issue in Chinese into English #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Conversation

Rory-Z
Copy link
Member
@Rory-Z Rory-Z commented May 29, 2025

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #123

What is the new behavior?

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

Signed-off-by: Rory Z <16801068+Rory-Z@users.noreply.github.com>
@Rory-Z Rory-Z force-pushed the ci/translate-issue branch from 8aa6c1c to 88696bb Compare May 29, 2025 02:32
@Rory-Z Rory-Z merged commit 3aaa686 into main May 29, 2025
4 checks passed
@Rory-Z Rory-Z deleted the ci/translate-issue branch May 29, 2025 03:13
@github-project-automation github-project-automation bot moved this to Done in MQTTX May 29, 2025
@ysfscream ysfscream requested review from ysfscream and Copilot May 29, 2025 05:56
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Ove 8000 rview

This PR adds a new GitHub Action workflow to automatically translate issue content from Chinese to English.

  • Introduces a workflow triggered on both manual dispatch and issue creation
  • Supports translation by invoking an external action with a provided GEMINI API key

issues: write # Grant permission to edit issues
steps:
- uses: emqx/translate-issue-action@ee63ec619dfc5808ee2093dba93dfd7ac3beb437 # v1.0.2
with:
Copy link
Preview
Copilot AI May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding an inline comment to explain the conditional logic selecting the issue number for clarity and easier future maintenance.

Suggested change
with:
with:
# Select the issue number based on the event type:
# - If triggered manually (workflow_dispatch), use the provided input issue_number.
# - Otherwise, use the issue number from the issue event.

Copilot uses AI. Check for mistakes.

@ysfscream ysfscream added this to the v1.12.0 milestone May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants
0