8000 Up wsproto to 1.0.0 by euri10 · Pull Request #892 · encode/uvicorn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Up wsproto to 1.0.0 #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 25, 2021
Merged

Up wsproto to 1.0.0 #892

merged 15 commits into from
Feb 25, 2021

Conversation

euri10
Copy link
Member
@euri10 euri10 commented Dec 13, 2020 •
edited
Loading

Fixes #868

We have a few tests failing if using wsproto 1.0.* vs the one pinned that was 0.15.*

As noticed in the issue, the main difference comes from this diff in src/wsproto/handshake.py where status_code=426, becomes status_code=426 if version else 400,

so the 426 we test in test_supported_upgrade_request can only appear if there is at least the Sec-WebSocket-Version header, and in order for the 426 to appear it need to bea wrong version.

Same reasoning on test_invalid_upgrade we provide a wrong sec-websocket-version (11 instead of 13) to trigger the 426 in wsproto and 400 on websockets

@ghost
Copy link
ghost commented Dec 14, 2020

Stop send me please.

@euri10 euri10 marked this pull request as ready for review December 30, 2020 16:53
florimondmanca
florimondmanca approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member
@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@euri10 LGTM. Let's mark this for 0.14. :)

@florimondmanca florimondmanca added this to the 0.14.0 milestone Dec 30, 2020
@euri10
Copy link
Member Author
euri10 commented Jan 1, 2021 via email

@euri10
Copy link
Member Author
euri10 commented Feb 24, 2021

@euri10 LGTM. Let's mark this for 0.14. :)

care to explain this @florimondmanca ? should I merge or not ?

@florimondmanca
Copy link
Member

@euri10 At the time I thought that if we merged this then it would require the next release to be 0.14 (minor bump rather than patch since this might break things and it's somewhat of an addition). I still think that's the case, but it didn't really mandate blocking anything. Feel free to merge. :)

@euri10 euri10 merged commit 9dc5a43 into encode:master Feb 25, 2021
@euri10 euri10 deleted the wsproto1.0 branch February 26, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

5A9B @florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

Three tests failing on openSUSE rpm VMs
2 participants
@euri10 @florimondmanca
0