Fixed counter on failed connection #283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe I have been encountering this issue, so it would be great to see this or something similar to it merged. |
|
Looks like it just needs a unittest. |
aminalaee
reviewed
Sep 9, 2021
taybin
reviewed
Sep 9, 2021
|
I'll try to add the test for new code, @taybin feel free to add that if you like. |
|
I'm working on a unittest for this right now. |
|
@aminalaee I have a PR with @qweryty's code and a unittest at #385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
self._connection.acquire()can throw an exception andself._connection_counterwill remain 1, in that case, if we try to reconnect__aenter__will always skipself._connection.acquire()and we won't be able to make any further requests to database.