8000 Version 0.5.2 by aminalaee · Pull Request #386 · encode/databases · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Version 0.5.2 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2021
Merged

Version 0.5.2 #386

merged 2 commits into from
Sep 10, 2021

Conversation

aminalaee
Copy link
Member
@aminalaee aminalaee commented Sep 10, 2021 •
edited
Loading

@aminalaee aminalaee requested review from PrettyWood and a team September 10, 2021 06:33
@tomchristie
Copy link
Member

Great... d'ya want to create a release draft to go along with this?...

  1. Fill in the "tag", "title", and "description".
  2. Make sure to hit the "Save draft" button, not the "Publish release" button.
  3. Include the URL for that in this ticket, so that I can review both this, and the release draft.
  4. Once reviewed we'll merge this PR.
  5. Then we'll publish the release.

(I know you've done this process before, but I have to remind myself sometimes too, and I think it's helpful for visibility of our process to go over all this step-by-step, right?) 😀

@aminalaee
Copy link
Member Author
aminalaee commented Sep 10, 2021 •
edited
Loading

@tomchristie You're right. That makes more sense 👍
I created the draft release, updated PR description to include the link.

tomchristie
tomchristie approved these changes Sep 10, 2021
8000
View reviewed changes
Copy link
Member
@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@aminalaee aminalaee merged commit 2150a22 into master Sep 10, 2021
@aminalaee aminalaee deleted the version-0.5.2 branch September 10, 2021 11:12
aminalaee added a commit that referenced this pull request Sep 11, 2021
@aminalaee
swtiching to TEST_DATABASE_URL
339e106 
Avoid dangling task-local connections after Database.disconnect() (#211)

Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com>

Reset counter for failed connections (#385)

Co-authored-by: Sergey Morozov <sergey@morozov.top>

Version 0.5.2 (#386)

update requirements

change scripts

update pytest config

update pytest

Update requirements

update workflow

try cache in workflow

disable coverage for py3.6

use cache in env

fix workflow

cache keys

update coverage workflow

test

test again

test

use absoulte path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

@PrettyWood PrettyWood Awaiting requested review from PrettyWood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminalaee @tomchristie
0