8000 Add support for auto_now and auto_now_add by Mng-dev-ai · Pull Request #140 · encode/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for auto_now and auto_now_add #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 24, 2021
Merged

Add support for auto_now and auto_now_add #140

merged 9 commits into from
Dec 24, 2021

Conversation

Mng-dev-ai
Copy link
Contributor

No description provided.

@Mng-dev-ai
Copy link
Contributor Author

What's the problem ?

@aminalaee
Copy link
Member

You can check here https://github.com/encode/orm/runs/4531378456?check_suite_focus=true.
You need to run ./scripts/lint locally.

@Mng-dev-ai
Copy link
Contributor Author

Oh I forgot about this.
Fixed

@Mng-dev-ai
Copy link
Contributor Author

How to fix coverage issue ?

aminalaee
aminalaee reviewed Dec 15, 2021
View reviewed changes
aminalaee
aminalaee reviewed Dec 17, 2021
View reviewed changes
aminalaee
aminalaee reviewed Dec 18, 2021
View reviewed changes
aminalaee
aminalaee reviewed Dec 23, 2021
View reviewed changes
Copy link
Member
@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you.
Can you add the related docs too? It would be perfect.

@Mng-dev-ai
Copy link
Contributor Author

I checked the docs now but I can't see where I can add the docs ?
Maybe in Declaring Models section ?

@aminalaee
Copy link
Member

Yes, I think it can go in the Data Types.
Maybe something like what's done for orm.String(max_length) or if you feel like it needs more clarification, have a section before The following column types are supported. this.

aminalaee
aminalaee approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member
@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this

@aminalaee aminalaee merged commit d4b508a into encode:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mng-dev-ai @aminalaee
0