8000 Make StreamingResponse compatible with normal iterators by tiangolo · Pull Request #461 · encode/starlette · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make StreamingResponse compatible with normal iterators #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Make StreamingResponse compatible with normal iterators #461

wants to merge 4 commits into from

Conversation

tiangolo
Copy link
Member
@tiangolo tiangolo commented Apr 2, 2019

Make StreamingResponse compatible with normal iterators.

Continuing from #457, #457 (comment)

I also removed the mention to iterator_to_async from the docs, only mention that it supports both async and normal generators.

I'd also be interested in if there's any nice ways around we could use something like this and drop aiofiles [...]

Let's see what do you think about this one and then I'll take a stab at that 😄

tomchristie
tomchristie reviewed Apr 2, 2019
View reviewed changes
starlette/concurrency.py Outdated
raise _StopSyncIteration


async def iterator_to_async(iterator: Iterator) -> AsyncGenerator:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about iterate_in_threadpool to mirror run_in_threadpool.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. I struggled a lot to name it and wasn't quite convinced either.

@tomchristie
Copy link
Member

Do we strictly need the _StopSyncIteration indirection?

@tomchristie
Copy link
Member

Can we not catch StopIteration directly?

@tiangolo
Copy link
Member Author
tiangolo commented Apr 2, 2019 •
edited
Loading

StopIteration is used internally by coroutines, it was used before to yield values, here's a short summary in the PEP: https://www.python.org/dev/peps/pep-0492/#why-stopasynciteration

I can think of an alternative using classes, based on this example: https://www.python.org/dev/peps/pep-0492/#example-2, would you prefer that?

@tiangolo
Copy link
Member Author
tiangolo commented Apr 2, 2019

Because StopIteration was used to yield values, catching it directly in iterate_in_threadpool is not possible, it is converted to a RuntimeError.

Actually, now that I think of it, using a class would still need the indirection, as we need an exception that is propagated up/out even when run inside of run_in_threadpool.

@tomchristie tomchristie mentioned this pull request Apr 3, 2019
Merged
@tomchristie
Copy link
Member

👍 Released as prerelease version 0.12.0b3

@tomchristie tomchristie closed this Apr 3, 2019
@tiangolo
Copy link
Member Author
tiangolo commented Apr 3, 2019

Awesome! Thanks! 🎉 🚀

@tiangolo tiangolo deleted the iterator-to-async branch April 3, 2019 16:06
@tiangolo tiangolo mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiangolo @tomchristie
0