8000 Return 404 Not Found for accessing file as directory pattern by xKerman · Pull Request #1124 · encode/starlette · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Return 404 Not Found for accessing file as directory pattern #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Return 404 Not Found for accessing file as directory pattern #1124

wants to merge 2 commits into from

Conversation

xKerman
Copy link
@xKerman xKerman commented Jan 11, 2021

fixes #1123

@xKerman
Copy link
Author
xKerman commented Jan 11, 2021

Hmm, it seems that test suite failure on python 3.8 is caused by pytest update.
On my machine, test passes after downgrading pytest from 6.2.1 to 6.1.2.

@xKerman xKerman marked this pull request as ready for review January 11, 2021 08:32
@JayH5
Copy link
Member
JayH5 commented Feb 2, 2021

This seems like a good change, but my first thought is wondering if there are other exceptions we should be catching too, e.g. PermissionError 🤔 or even a more general error like OSError. I'm not really sure, and if somebody could do some experimentation/research that'd be great.

@JayH5 JayH5 added the staticfiles Static file serving label Feb 4, 2021
@aminalaee aminalaee mentioned this pull request Jun 27, 2021
Merged
@WhiteApfel WhiteApfel mentioned this pull request Oct 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
staticfiles Static file serving
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StaticFiles causes Internal Server Error when user accesses existing files as directory
2 participants
@xKerman @JayH5
0