8000 Use `localhost` instead of `http://localhost` in `TestClient(client=...)` example by WilliamDEdwards · Pull Request #2870 · encode/starlette · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use localhost instead of http://localhost in TestClient(client=...) example #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

Use localhost instead of http://localhost in TestClient(client=...) example #2870

merged 1 commit into from
Feb 16, 2025

Conversation

WilliamDEdwards
Copy link
Contributor

Summary

With #2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address).

The default value for TestClient is testclient, but an IP address in most circumstances.

The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@WilliamDEdwards
Fix client host override example
fdfbee9 
With encode#2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address).

The default value for `TestClient` is `testclient`, but an IP address in most circumstances.

The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.
@Kludex Kludex changed the title Fix client host override example Use localhost instead of http://localhost in TestClient(client=...) example Feb 16, 2025
@Kludex Kludex merged commit 1695942 into encode:master Feb 16, 2025
5 checks passed
@Kludex
Copy link
Member
Kludex commented Feb 16, 2025

Thanks 🙏

This was referenced Apr 1, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamDEdwards @Kludex
0