8000 runtimes/js: fix setting of multi-headers by fredr · Pull Request #1903 · encoredev/encore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

runtimes/js: fix setting of multi-headers #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Conversation

fredr
Copy link
Member
@fredr fredr commented May 9, 2025

subtle difference,

for (k, v) in headers

yeilds each key only once, for multiple values it will be set to None the second time

for (k, v) in headers.iter()

yeilds the same key for each value (https://docs.rs/http/latest/http/header/struct.HeaderMap.html#method.iter)

@fredr fredr requested a review from eandre May 9, 2025 09:43
@encore-cla
Copy link
encore-cla bot commented May 9, 2025

All committers have signed the CLA.

@fredr fredr merged commit 123d386 into main May 9, 2025
4 checks passed
@fredr fredr deleted the fredr/ts-fix-multi-header branch May 9, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0