8000 WRQ-19328: Fix React 18.3 warnings in enact by juwonjeong · Pull Request #3238 · enactjs/enact · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WRQ-19328: Fix React 18.3 warnings in enact #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 22, 2024
Merged

WRQ-19328: Fix React 18.3 warnings in enact #3238

merged 6 commits into from
May 22, 2024

Conversation

juwonjeong
Copy link
Contributor
@juwonjeong juwonjeong commented May 17, 2024 •
edited
Loading

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

In React 19, defaultProps in function components will be removed.
In React 18.3, There are warnings for key spreading

Resolution

Remove defaultProps for function components and replaced them with ES6 default parameters.
Pass key directly to JSX without using spread

Additional Considerations

Links

WRQ-19328

Comments

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)

juwonjeong added 2 commits May 16, 2024 09:52
@juwonjeong
Fix key spread warning
66a077b 
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@juwonjeong
Replace defaultProps with ES6 default parameters
469b272 
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@codecov Codecov
Copy link
codecov bot commented May 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (7c03337) to head (1ae90ef).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3238      +/-   ##
===========================================
+ Coverage    82.41%   82.42%   +0.01%     
===========================================
  Files          156      156              
  Lines         7209     7214       +5     
  Branches      1907     1912       +5     
===========================================
+ Hits          5941     5946       +5     
  Misses         997      997              
  Partials       271      271

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

juwonjeong added 3 commits May 20, 2024 23:11
@juwonjeong
Use Object.assign when implementing defaultProps
1f7bd75 
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@juwonjeong
Fix Sprite, Scroller, VirtualList to show default prop values properl…
802f642 
…y in sampler

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@juwonjeong
Update React to version 18.3.1
a291440 
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
MikyungKim
MikyungKim reviewed May 21, 2024
View reviewed changes
MikyungKim
MikyungKim reviewed May 21, 2024
View reviewed changes
MikyungKim
MikyungKim reviewed May 21, 2024
View reviewed changes
MikyungKim
MikyungKim reviewed May 21, 2024
View reviewed changes
@juwonjeong
Apply review
1ae90ef 
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
MikyungKim
MikyungKim approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor
@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikyungKim MikyungKim merged commit 88a8271 into develop May 22, 2024
7 checks passed
@MikyungKim MikyungKim deleted the feature/WRQ-19328 branch May 22, 2024 07:22
@juwonjeong juwonjeong mentioned this pull request Aug 8, 2024
Merged
5 tasks
@juwonjeong juwonjeong mentioned this pull request 7255 Aug 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikyungKim MikyungKim MikyungKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juwonjeong @MikyungKim
0