8000 PLAT-130738: [sandstone/Picker] Add prop `type` to use aria-label from app by Sangwook-Lee · Pull Request #820 · enactjs/sandstone · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PLAT-130738: [sandstone/Picker] Add prop type to use aria-label from app #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

PLAT-130738: [sandstone/Picker] Add prop type to use aria-label from app #820

wants to merge 3 commits into from

Conversation

Sangwook-Lee
Copy link
Contributor
@Sangwook-Lee Sangwook-Lee commented Dec 31, 2020 •
edited
Loading

Checklist

  • I have read and understand the contribution guide

  • A CHANGELOG entry is included

  • At least one test case is included for this feature or bug fix

  • Documentation was added or is not needed

  • This is an API breaking change

Issue Resolved / Feature Added

Resolution

Additional Considerations

Links

Comments

jeonghee27
jeonghee27 approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor
@jeonghee27 jeonghee27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeonghee27 added 2 commits May 24, 2021 15:35
@jeonghee27
Merge branch 'develop' into feature/PLAT-130738
c7bec30
@jeonghee27
Fix mistake on merge develop
6a832b0 
Enact-DCO-1.0-Signed-off-by: Jeonghee Ahn (jeonghee27.ahn@lge.com)
@codecov
Copy link
codecov bot commented May 24, 2021 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (7e3bd42) to head (6a832b0).
Report is 868 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #820   +/-   ##
========================================
  Coverage    52.43%   52.43%           
========================================
  Files          134      134           
  Lines         5986     5986           
  Branches      1707     1707           
========================================
  Hits          3139     3139           
  Misses        2221     2221           
  Partials       626      626

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CLAassistant
Copy link
CLAassistant commented Oct 29, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeonghee27 jeonghee27 jeonghee27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sangwook-Lee @CLAassistant @jeonghee27
0