8000 Add missing namespace for xlink logo in SvgWriter by sprain · Pull Request #359 · endroid/qr-code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing namespace for xlink logo in SvgWriter #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Add missing namespace for xlink logo in SvgWriter #359

merged 2 commits into from
Dec 13, 2021

Conversation

sprain
Copy link
Contributor
@sprain sprain commented Dec 13, 2021

This missing namespace causes the logo to not appear when embedding the qr code in a pdf.

@endroid endroid merged commit 361b43b into endroid:master Dec 13, 2021
@endroid endroid self-assigned this Dec 13, 2021
@endroid endroid added the enhancement New feature or request label Dec 13, 2021
@sprain sprain deleted the svg-xlink-improvement branch December 13, 2021 11:07
@sprain
Copy link
Contributor Author
sprain commented Dec 15, 2021

Thanks for merging so quickly!
Are you planning to release a patch version for this anytime soon?

@endroid
Copy link
Owner
endroid commented Dec 15, 2021

Hi @sprain tagged 4.4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0