Fixing image binary output #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thank you! |
|
Sorry to say, but you shouldn't call both "ob_end_flush" and "ob_get_clean". Both end the current buffer. Which causes PHP to the give following error: "PHP Notice: ob_end_flush(): failed to delete and flush buffer. No buffer to delete or flush in XXX on line YYY". @endroid : Please undo this commit. @karisters : You must have a bug somewhere else in your project :-( |
|
Yes, this commit is wrong. We get this error after update: |
|
@casperbiering and @kukulich You're right. This should be fixed in 1.6.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guys, we had problems with uncaught binary output in our project.
Cheers!