Exclude maps from swipe action DEV-181 #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuukis
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
LGTM, can repro the bug and confirm a fix on both emulated desktop browser (Firefox) and Android browsers (Firefox embed, Firefox, Brave).
For the record, if a swipe starts outside of map box in the left or right margin, it will still navigate the back n forth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1359
I have verified this PR works with
Why is this the best possible solution? Were any other approaches considered?
This is the simplest and recommended solution.
The exclusion of elements is a deature of the lib:
https://www.npmjs.com/package/jquery-touchswipe/v/1.6.7
http://labs.rampinteractive.co.uk/touchSwipe/docs/tutorial-Excluded_children.html
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No risk of regression.
This PR only affects swipe actions, excluding an specific class used for maps, therefore avoiding triggering the swipe actions when interacting to maps.
Do we need any specific form for testing your changes? If so, please attach one.
It can be tested with the form attached to issue #1359: XLSForm_map_panning_bug.xlsx
Also in XML format (needs to be renamed from .txt to .xml): XLSForm_map_panning_bug.xml.txt