8000 File browser extensions by vitvakatu · Pull Request #13048 · enso-org/enso · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

File browser extensions #13048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
May 22, 2025
Merged

File browser extensions #13048

merged 33 commits into from
May 22, 2025

Conversation

vitvakatu
Copy link
Contributor
@vitvakatu vitvakatu commented May 7, 2025 •
edited
Loading

Pull Request Description

Closes #12004

Note that the extension lists are mocked in the videos below, so you will not see the same result in the app until the libs configuration is updated.

In cloud browser:

file-extensions-cloud.mp4

In native browser:

file-extensions-native.mp4

Latest version (includes changes from the latest develop):

updated-file-extensions-cloud.mp4

In read-mode file browser:

file-extensions-readonly.mp4

Important Notes

Interaction handler now supports nested interactions. I’m not 100% happy with the API, but I suggest gather more usage patterns before improving it if necessary.

Also, deep refactoring of the SelectionSubmenu widget, making it more universal.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@vitvakatu vitvakatu self-assigned this May 7, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 7, 2025 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@vitvakatu vitvakatu force-pushed the wip/vitvakatu/file-browser-extensions-12004 branch from 47cf099 to 03ab33a Compare May 14, 2025 09:39
@vitvakatu vitvakatu changed the title [WIP] File browser extensions File browser extensions May 14, 2025
@vitvakatu vitvakatu marked this pull request as ready for review May 14, 2025 09:44
@vitvakatu
Copy link
Contributor Author
vitvakatu commented May 20, 2025 •
edited
Loading

Merge with develop done, addressed final review comments, and added support for read-only file browser mode. I also fixed a few spotted bugs in the develop code:

  • Z-ordering of the modal was broken, allowing interaction with “hidden” buttons
  • CSS for the confirmation button was broken
  • The widget was not closing after accepting a file, which I assume is not an expected behavior (compared to ~3 weeks old develop)

Updated the top post with additional videos, ready for re-review.

@vitvakatu vitvakatu requested review from kazcw and farmaazon May 20, 2025 20:40
@github-actions github-actions bot added the -libs-API-change-Base Marks a PR that changes the public API of Standard.Base label May 21, 2025
farmaazon
farmaazon approved these changes May 21, 2025
View reviewed changes
app/gui/src/project-view/components/widgets/FileBrowserWidget/FileBrowserNameBar.vue
Comment on lines +38 to +39
// === File Extension Filter ===

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to go, but I would still at some point make it a component separate from FileBrowserNameBar - just not not have everything prefixed with fileExtension ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I tried doing that, but splitting the components is difficult because they are interconnected. I will leave it as it is.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 21, 2025 •
edited
Loading

✨ GUI Checks Results

Summary

  • 🧹 Prettier: ✅ Passed
  • 🧰 GUI Checks: ✅ Passed
  • 📚 Storybook: ✅ Deployed

✅ All checks passed! Your changes look good to go.

See individual check results for more details.

ℹ️ Chromatic Tests Skipped

Chromatic visual regression tests were skipped for this PR.

To run the tests and deploy Storybook, add the CI: Run Chromatic label to this PR.

Note: We skip tests by default to optimize CI costs. Only run them when your UI changes are ready for review.

👮 Lint GUI Results

Check Results

  • 🧠 Typecheck: ✅ Passed
  • 🧹 Lint: ✅ Passed
  • 🧪 Unit Tests: ✅ Passed

🎭 Playwright Test Results

Summary

  • ⏳ Duration: 6m 0s
  • ✅ Passed: 338 tests
  • 🔴 Failed: 0 tests
  • ⚠️ Flaky: 0 tests

📥 Download Detailed Report

✅ All tests passed! Your changes look good.

@vitvakatu
Copy link
Contributor Author

@AdRiley @jdunkerley could you review the libs modifications?

@vitvakatu vitvakatu added CI: Ready to merge This PR is eligible for automatic merge -gui labels May 22, 2025
@mergify mergify bot merged commit e1ee481 into develop May 22, 2025
88 of 91 checks passed
6D40
@mergify mergify bot deleted the wip/vitvakatu/file-browser-extensions-12004 branch May 22, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdRiley AdRiley AdRiley approved these changes

@farmaazon farmaazon farmaazon approved these changes

@somebody1234 somebody1234 somebody1234 approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@MrFlashAccount MrFlashAccount Awaiting requested review from MrFlashAccount

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

Assignees

@vitvakatu vitvakatu

Labels
-gui -libs-API-change-Base Marks a PR that changes the public API of Standard.Base CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File extension support for file browse widgets
5 participants
@vitvakatu @kazcw @AdRiley @farmaazon @somebody1234
0