8000 Dataflow Errors by iamrecursion · Pull Request #1433 · enso-org/enso · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dataflow Errors #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 27, 2021
Merged

Dataflow Errors #1433

merged 8 commits into from
Jan 27, 2021

Conversation

iamrecursion
Copy link
Contributor

Pull Request Description

This PR adds comprehensive support for dataflow errors throughout the interpreter. This means that they can flow through far more places in the graph, providing a far better UX. In addition, it adds support for PanicSentinel, a marker used by the runtime instrumentation to trace the effects of panics.

Closes #1409.

Important Notes

There is no performance impact from these changes in compiled code.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP labels Jan 27, 2021
@iamrecursion iamrecursion requested a review from kustosz January 27, 2021 10:23
@iamrecursion iamrecursion self-assigned this Jan 27, 2021
kustosz
kustosz approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor
@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful stuff, land it if fixing that one gobbledygook in the bingading does not break the benchmarks

@iamrecursion iamrecursion merged commit e83b18f into main Jan 27, 2021
@iamrecursion iamrecursion deleted the wip/ara/more-dataflow branch January 27, 2021 13:41
iamrecursion added a commit that referenced this pull request Feb 10, 2021
@iamrecursion
Improve the handling of dataflow errors (#1433)
9ee2873
iamrecursion added a commit that referenced this pull request Feb 11, 2021
@iamrecursion
Improve the handling of dataflow errors (#1433)
545f01e
iamrecursion added a commit that referenced this pull request Feb 11, 2021
@iamrecursion
Improve the handling of dataflow errors (#1433)
a696792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kustosz kustosz kustosz approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@iamrecursion iamrecursion

Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Support for Dataflow Errors to Work with the IDE
2 participants
@iamrecursion @kustosz
0