8000 Enhance the Standard Library's Usage of Dataflow Errors by iamrecursion · Pull Request #1446 · enso-org/enso · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enhance the Standard Library's Usage of Dataflow Errors #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 2, 2021
Merged

Enhance the Standard Library's Usage of Dataflow Errors #1446

merged 8 commits into from
Feb 2, 2021

Conversation

iamrecursion
Copy link
Contributor
@iamrecursion iamrecursion commented Feb 1, 2021 •
edited
Loading

Pull Request Description

This PR enhances the standard library to use dataflow errors where appropriate. It also enhances the testing framework to behave better in the presence of dataflow errors.

Closes #1444
Closes #1410

Important Notes

This is a breaking change to the standard library's API.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP labels Feb 1, 2021
@iamrecursion iamrecursion requested a review from kustosz February 1, 2021 17:15
@iamrecursion iamrecursion self-assigned this Feb 1, 2021
kustosz
kustosz approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor
@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Some changes / discussions inline

@iamrecursion iamrecursion merged commit af1aab3 into main Feb 2, 2021
@iamrecursion iamrecursion deleted the wip/ara/dataflow branch February 2, 2021 12:31
@radeusgd radeusgd mentioned this pull request Feb 10, 2021
Closed
1 task
iamrecursion added a commit that referenced this pull request Feb 10, 2021
@iamrecursion
Improve dataflow errors in the standard library (#1446)
3dd7173
iamrecursion added a commit that referenced this pull request Feb 11, 2021
@iamrecursion
Improve dataflow errors in the standard library (#1446)
d0aab83
iamrecursion added a commit that referenced this pull request Feb 11, 2021
@iamrecursion
Improve dataflow errors in the standard library (#1446)
158461f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kustosz kustosz kustosz approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@iamrecursion iamrecursion

Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector Fails to map Over Error Update the Standard Library to use Dataflow Errors
2 participants
@iamrecursion @kustosz
0