8000 Enable git-repo-path to choose its source directory. by titanlien · Pull Request #9 · entrostat/git-secret-action · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable git-repo-path to choose its source directory. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable git-repo-path to choose its source directory. #9

wants to merge 2 commits into from

Conversation

titanlien
Copy link
  • git-repo-path is storing directory .gitsecret

@titanlien titanlien force-pushed the feature/add-git-repo-path branch from 384ff33 to cf9152b Compare September 23, 2024 15:28
@titanlien titanlien force-pushed the feature/add-git-repo-path branch 2 times, most recently from e9440e9 to 8c4c396 Compare September 24, 2024 14:30
@kerren
Copy link
Contributor
kerren commented Sep 24, 2024

@titanlien what would a use case for this be? Is it when you have a submodule?

kerren
kerren requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor
@kerren kerren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably make a change here in terms of the description?

@titanlien @kerren
Update action.yml
bb01ac0 
Co-authored-by: Kerren Ortlepp <kerren@entrostat.com>
@titanlien
Copy link
Author
titanlien commented Sep 25, 2024 •
edited
Loading

@titanlien what would a use case for this be? Is it when you have a submodule?

When we use actions/checkout@v4 image like the following setting. Then this image can't find its checkout secrets-directory directory.

      - name: Git clone the secrets repository
        uses: actions/checkout@v4
        with:
          repository: secrets-repo
          ref: ...
          token: ...
          path: secrets-directory

@titanlien titanlien requested a review from kerren September 25, 2024 08:07
604E Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerren kerren Awaiting requested review from kerren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titanlien @kerren
0