8000 Generalize specification helpers by gsps · Pull Request #828 · epfl-lara/stainless · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Generalize specification helpers #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 25, 2020
Merged

Generalize specification helpers #828

merged 10 commits into from
Nov 25, 2020

Conversation

gsps
Copy link
Contributor
@gsps gsps commented Aug 26, 2020

This PR unifies the handling of specification helpers, so it becomes easier to add new kinds of specs.

@gsps gsps changed the title Generalize specifications Generalize specification helpers Aug 26, 2020
@gsps
Copy link
Contributor Author
gsps commented Sep 24, 2020

To be d 8000 one: Investigate why the assertion that ensures we only have one contract of each kind triggers.

@gsps gsps force-pushed the generalized-specs branch from 6b7e060 to e1aaab0 Compare September 24, 2020 22:05
brunnerant
brunnerant approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor
@brunnerant brunnerant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is way cleaner that way !
If you want, I can try to debug the missing tests so that this PR is ready to be merged (because I will definitely need your nice infrastructure to add the two new contracts for my project).

@gsps gsps force-pushed the generalized-specs branch from dbe1a83 to d302eb2 Compare November 24, 2020 10:45
@gsps gsps requested a review from jad-hamza November 24, 2020 11:08
@gsps
Copy link
Contributor Author
gsps commented Nov 24, 2020

@jad-hamza Feel free to review superficially, mostly adding you to keep you in the loop on changes to specs infrastructure.

@gsps gsps merged commit 4f1c36f into master Nov 25, 2020
@gsps gsps deleted the generalized-specs branch November 25, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunnerant brunnerant brunnerant approved these changes

@jad-hamza jad-hamza Awaiting requested review from jad-hamza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsps @brunnerant
0