8000 Add font size legacy by williambelle · Pull Request #570 · epfl-si/elements · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add font size legacy #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2022
Merged

Add font size legacy #570

merged 1 commit into from
Mar 25, 2022

Conversation

williambelle
Copy link
Member

No description provided.

@github-actions
Copy link

Unit Test Results

    1 files      1 suites   0s ⏱️
255 tests 253 ✔️ 0 💤 0 ❌ 2 🔥
255 runs  251 ✔️ 0 💤 2 ❌ 2 🔥

For more details on these errors, see this check.

Results for commit 374acb8.

@github-actions
Copy link

🔎 Download the Backstop report for this pull request (link valid for 90 days):

@williambelle williambelle marked this pull request as ready for review March 22, 2022 12:37
@williambelle
Copy link
Member Author

(Volontairement aucune documentation pour ne pas inciter à utiliser.)

@williambelle williambelle requested a review from xentenza March 22, 2022 12:39
xentenza
xentenza reviewed Mar 22, 2022
View reviewed changes
Copy link
Collaborator
@xentenza xentenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williambelle Quel serait le cadre d'utilisation? Et pourquoi ne pas le documenter?

@williambelle
Copy link
Member Author

@williambelle Quel serait le cadre d'utilisation? Et pourquoi ne pas le documenter?

Ces classes sont déjà utilisées dans Actu et Memento pour contrôler la taille de certain élément.

Il ne faut pas les documenter car les tailles ne correspondent pas à la définition de Bootstrap.

elements/assets/config/bootstrap-variables.scss

Lines 218 to 221 in 7a0efab

$font-size-base: 1rem !default; // Assumes the browser default, typically `16px`
$font-size-lg: ($font-size-base * 1.25) !default;
$font-size-sm: ($font-size-base * .83) !default;
$font-size-xs: 0.778rem;

Il y a déjà d'autres classes qui ne sont pas documentée comme :

elements/assets/config/helpers.scss

Lines 76 to 78 in 7a0efab

.text-small {
font-size: $font-size-xs;
}

Ces classes pourront être supprimées lors de la prochaine version majeure de Elements.
Par exemple, Bootstrap v5 fournit : https://getbootstrap.com/docs/5.0/utilities/text/#font-size

@xentenza
Copy link
Collaborator

Ok, merci pour les précisions!

@xentenza xentenza merged commit b8de516 into dev Mar 25, 2022
@williambelle williambelle deleted the feature/font-size-legacy branch March 28, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xentenza xentenza xentenza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williambelle @xentenza
0