8000 Rename image portrait by williambelle · Pull Request #771 · epfl-si/elements · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename image portrait #771

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Rename image portrait #771

merged 1 commit into from
Feb 24, 2025

Conversation

williambelle
Copy link
Member

La taille de l'image est correcte mais le nom ne correspondait pas.

elements/assets/components/atoms/picture/picture-portrait.twig

Lines 2 to 18 in 2c24f00

<picture>
<source
media="(min-width: 1140px)"
srcset="{{portrait_path}}253x360.jpg 1x, {{portrait_path}}506x720.jpg 2x">
<source
media="(min-width: 960px)"
srcset="{{portrait_path}}211x300.jpg 1x, {{portrait_path}}422x600.jpg 2x">
<source
media="(min-width: 720px)"
srcset="{{portrait_path}}253x360.jpg 1x, {{portrait_path}}506x720.jpg 2x">
<source
media="(min-width: 541px)"
srcset="{{portrait_path}}253x360.jpg 1x, {{portrait_path}}506x720.jpg 2x">
<source
media="(max-width: 540px)"
srcset="{{portrait_path}}211x300.jpg 1x, {{portrait_path}}422x600.jpg 2x">
<img src="{{portrait_path}}506x720.jpg" class="img-fluid" alt="ALT">

@github-actions GitHub Actions
Copy link

Test Results

  1 files    1 suites   0s ⏱️
284 tests 266 ✅ 0 💤  0 ❌ 18 🔥
284 runs  248 ✅ 0 💤 18 ❌ 18 🔥

For more details on these errors, see this check.

Results for commit 739c77a.

@github-actions GitHub Actions
Copy link

🔎 Download the Backstop report for this pull request (link valid for 90 days):

@williambelle williambelle merged commit ec0f82c into dev Feb 24, 2025
4 checks passed
@williambelle williambelle deleted the fix/image-portait branch February 24, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinekeller alinekeller alinekeller approved these changes

@xentenza xentenza Awaiting requested review from xentenza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williambelle @alinekeller
0