8000 Fix srcset dimension for Listing square Thumbnail by williambelle · Pull Request #772 · epfl-si/elements · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix srcset dimension for Listing square Thumbnail #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

williambelle
Copy link
Member

L'image news_thumb-95x95.jpg n'existe pas et les dimensions 2x ne sont pas raccord.
J'ai modifié les dimensions mais c'est peut-être pas l'idée initiale.

Copy link

Test Results

  1 files    1 suites   0s ⏱️
284 tests 264 ✅ 0 💤  0 ❌ 20 🔥
284 runs  244 ✅ 0 💤 20 ❌ 20 🔥

For more details on these errors, see this check.

Results for commit 465efcf.

Copy link

🔎 Download the Backstop report for this pull request (link valid for 90 days):

Copy link
Contributor
@alinekeller alinekeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est très bien comme ça. Y'a pas une grande cohérence parmi ces srcet, j'ai essayé de faire un peu d'ordre quand j'avais retiré les sources qui venaient de placeholder.com, mais je pense que ça vaudrait la peine de vraiment se pencher là-dessus pour limiter le nombre de tailles d'images différentes.

@williambelle williambelle merged commit c305779 into dev Feb 24, 2025
4 checks passed
@williambelle williambelle deleted the fix/srcset-thumb-square branch February 24, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0